feat: network monitor transport layer integration#1660
Conversation
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Is there value in actually exercising the transport layer instead of relying on its self-reporting?
(for example, our own "health" report in the node might just always return Ok(200) 😬)
|
Current view of the monitor: 
|
Yes, there's value in that. I mostly wanted to have a first version introducing the transport layer, at least with an idea if the service is accessible. |
|
@Mirko-von-Leipzig is there a chance for the branch protection rules to have a typo? and be requiring "tests" instead of "test"? |
The issue is that I refactored |
Should be all good now. |
Mirko-von-Leipzig
deleted the
santiagopittella-network-monitor-transport-layer-integration
branch
3 participants
Warning
This PR aims to main.
This PR adds note transport layer support for the network monitor. It works by using the health check endpoint of the given service (https://github.com/0xMiden/miden-note-transport/blob/main/crates/node/src/node/grpc/mod.rs#L87)
Also, add a copy button for the URLs of the services to be easily accesible and re-arranges the order of the cards.